Bug 210996

Summary:

Call addExtraFieldsToRequest with current load type

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

New Bugs

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

cdumez, darin, ews-watchlist, japhet

Priority:

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Rob Buis 2020-04-24 14:18:16 PDT

Call addExtraFieldsToRequest with current load type, not the previous load type.

Comment 1 Rob Buis 2020-04-24 14:20:18 PDT

Created attachment 397508 [details]
Patch

Comment 2 Darin Adler 2020-04-24 16:32:03 PDT

Comment on attachment 397508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397508&action=review

> Source/WebCore/ChangeLog:8
> +        Call addExtraFieldsToRequest with current load type, not the previous load type.

Is there any observable progression from this? If so, can we make a test demonstrating it?

> Source/WebCore/loader/FrameLoader.cpp:1520
> +    ResourceRequest& request = newDocumentLoader.request();

I would have suggested auto& here.