| Summary: | [Web Animations] Ensure calling Web Animations APIs override future CSS Animations style properties | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2020-04-24 13:08:07 PDT
Created attachment 397495 [details]
Patch
Comment on attachment 397495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397495&action=review > Source/WebCore/animation/WebAnimation.cpp:151 > +void WebAnimation::setBindingsEffect(RefPtr<AnimationEffect>&& newEffect) > +{ > + setEffect(WTFMove(newEffect)); > +} Why does this need a different name for bindings? And the other two below. (In reply to Dean Jackson from comment #2) > Comment on attachment 397495 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397495&action=review > > > Source/WebCore/animation/WebAnimation.cpp:151 > > +void WebAnimation::setBindingsEffect(RefPtr<AnimationEffect>&& newEffect) > > +{ > > + setEffect(WTFMove(newEffect)); > > +} > > Why does this need a different name for bindings? And the other two below. Because CSSAnimation subclasses this method to apply some overrides. This needs to happen only when the effect is set via the JS API. Committed r260671: <https://trac.webkit.org/changeset/260671> |