Bug 210967

Summary: [GTK4] Make it possible to build with GTK4 without errors
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, berto, bugs-noreply, eric.carlson, ews-watchlist, glenn, gustavo, gyuyoung.kim, jbedard, jer.noble, philipj, ryuan.choi, sergio
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210100
Bug Depends on:    
Bug Blocks: 210100, 211021, 211045    
Attachments:
Description Flags
Patch
none
Patch
none
Patch aperez: review+

Carlos Garcia Campos
Reported 2020-04-24 06:55:16 PDT
Therew will be warnings for sure, though. The idea is to ifdef everything so that we can have a complete build with GTK4 and then start working on every feature independently checking it actually works.
Attachments
Patch (197.80 KB, patch)
2020-04-24 07:06 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (197.82 KB, patch)
2020-04-24 07:13 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (197.76 KB, patch)
2020-04-25 06:45 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-04-24 07:06:11 PDT
Created attachment 397453 [details] Patch
EWS Watchlist
Comment 2 2020-04-24 07:06:57 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2020-04-24 07:13:29 PDT
Created attachment 397455 [details] Patch
Carlos Garcia Campos
Comment 4 2020-04-25 06:45:58 PDT
Created attachment 397562 [details] Patch This should fix the api tests.
Adrian Perez
Comment 5 2020-04-27 05:59:17 PDT
(In reply to Carlos Garcia Campos from comment #3) > Created attachment 397455 [details] > Patch Let's land this. I think we will have more patch review discussion when implementing back some of the things which will be left unimplemented for GTK4 with this, but for now stubbing them out to allow the build to complete is fine, IMO.
Carlos Garcia Campos
Comment 6 2020-04-27 06:10:18 PDT
Committed r260752: <https://trac.webkit.org/changeset/260752>
Note You need to log in before you can comment on or make changes to this bug.