Bug 210956

Summary: [JSC] DFG AI for some bitops + BigInt32 should be precise
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch keith_miller: review+

Description Yusuke Suzuki 2020-04-24 00:56:25 PDT
[JSC] DFG AI for some bitops + BigInt32 should be precise
Comment 1 Yusuke Suzuki 2020-04-24 00:57:10 PDT
Created attachment 397435 [details]
Patch
Comment 2 Yusuke Suzuki 2020-04-24 01:00:47 PDT
Created attachment 397437 [details]
Patch
Comment 3 Keith Miller 2020-04-24 09:59:47 PDT
Comment on attachment 397437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397437&action=review

r=me.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:543
>          // FIXME: this use of binaryUseKind means that we cannot specialize to (for example) a HeapBigInt left-operand and a BigInt32 right-operand.

Can we file a bug for this?
Comment 4 Yusuke Suzuki 2020-04-24 10:15:30 PDT
Comment on attachment 397437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397437&action=review

Thanks!

>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:543
>>          // FIXME: this use of binaryUseKind means that we cannot specialize to (for example) a HeapBigInt left-operand and a BigInt32 right-operand.
> 
> Can we file a bug for this?

Added.
Comment 5 Yusuke Suzuki 2020-04-24 10:20:09 PDT
Committed r260651: <https://trac.webkit.org/changeset/260651>
Comment 6 Radar WebKit Bug Importer 2020-04-24 10:21:17 PDT
<rdar://problem/62321935>