| Summary: | Resize cursor doesn't show if there's text under the resize control | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | UI Events | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, akeerthi, rniwa, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | Safari Technology Preview | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=156234 | ||||||
| Attachments: |
|
||||||
It seems to be fixed with following Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=160554 It did changes here: https://github.com/WebKit/WebKit/blob/9856bc8b756610ac4e3a4a2c480e6332f50e0cd7/Source/WebCore/page/EventHandler.cpp#L1544 ___ Webkit (current): inResizer = layerRenderer.layer()->isPointInResizeControl(roundedIntPoint(result.localPoint())); Chrome Patch: inResizer = layer->isPointInResizeControl(result.roundedPointInMainFrame(), ResizerForPointer); *** Need to be changed *** inResizer = layerRenderer.layer()->isPointInResizeControl(roundedIntPoint(result.roundedPointInMainFrame(), localPoint); ___ If someone can confirm the approach, I am happy to do PR. Only problem / build error might be that it could only accept 1 argument but now we are providing it two. For that, if we can do: auto joined = roundedIntPoint(result.roundedPointInMainFrame(), localPoint); and then pass on single argument. To this: inResizer = layerRenderer.layer()->isPointInResizeControl(result.roundedPointInMainFrame(), localPoint); |
Created attachment 397385 [details] Test Hover over the resize cursor in the attached testcase. You don't see the resize cursor, instead getting an iBeam.