Bug 210931

Summary: stress/ensure-crash.js shouldn't spew stuff onto my screen
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, fpizlo, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Filip Pizlo
Reported 2020-04-23 12:08:13 PDT
JS tests should only spew things onto my screen if they succeed. ensure-crash appears to succeed but spews errors onto my screen. We should either skip it so it doesn't pollute a user's screen with errors that aren't errors or we should make it so that `crash!` or whatever makes the test not spew things unless it fails. run-jsc-stress-tests has the ability to log output and then only spew it if there was an actual error. We should use that.
Attachments
Patch (2.35 KB, patch)
2020-04-23 20:49 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.96 KB, patch)
2020-04-23 20:52 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2020-04-23 12:09:05 PDT
(In reply to Filip Pizlo from comment #0) > JS tests should only spew things onto my screen if they succeed. I mean if they fail. > > ensure-crash appears to succeed but spews errors onto my screen. > > We should either skip it so it doesn't pollute a user's screen with errors > that aren't errors or we should make it so that `crash!` or whatever makes > the test not spew things unless it fails. run-jsc-stress-tests has the > ability to log output and then only spew it if there was an actual error. > We should use that.
Yusuke Suzuki
Comment 2 2020-04-23 20:49:08 PDT
Created attachment 397418 [details] Patch
Yusuke Suzuki
Comment 3 2020-04-23 20:52:40 PDT
Created attachment 397419 [details] Patch
EWS
Comment 4 2020-04-23 22:14:26 PDT
Committed r260620: <https://trac.webkit.org/changeset/260620> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397419 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-23 22:15:19 PDT
<rdar://problem/62281561>
Note You need to log in before you can comment on or make changes to this bug.