Bug 210891

Summary:

[CMake] WebKit headers should be copies

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Don Olmstead <don.olmstead>

Status:

ASSIGNED

Severity:

Normal

CC:

annulen, berto, cgarcia, ews-watchlist, gustavo, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, svillar, tzagallo

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

222625

Bug Blocks:

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
WIP Patch	none
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
WIP Patch	none
WIP Patch	ews-feeder: commit-queue-

Don Olmstead

Reported 2020-04-22 18:50:50 PDT

...

Attachments
WIP Patch (17.01 KB, patch) 2020-04-22 18:51 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (19.27 KB, patch) 2020-04-22 19:13 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (9.95 KB, patch) 2021-03-02 08:03 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (11.56 KB, patch) 2021-03-02 08:07 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (11.65 KB, patch) 2021-03-02 08:21 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (12.39 KB, patch) 2021-03-02 08:26 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (13.79 KB, patch) 2021-03-02 08:42 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (14.52 KB, patch) 2021-03-02 09:22 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (15.80 KB, patch) 2021-03-02 09:55 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (16.26 KB, patch) 2021-03-02 10:09 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (16.85 KB, patch) 2021-03-02 11:02 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (16.85 KB, patch) 2021-03-02 11:19 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (17.95 KB, patch) 2021-03-02 11:34 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (18.43 KB, patch) 2021-03-02 11:38 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (18.61 KB, patch) 2021-03-02 11:49 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (19.69 KB, patch) 2021-03-02 12:05 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (20.28 KB, patch) 2021-03-02 12:20 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (19.78 KB, patch) 2021-03-02 12:35 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (43.64 KB, patch) 2021-03-03 07:11 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (46.34 KB, patch) 2021-03-03 07:32 PST, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (46.85 KB, patch) 2021-03-03 07:50 PST, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (28.72 KB, patch) 2021-03-03 08:08 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (35.49 KB, patch) 2021-03-03 09:01 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (19.62 KB, patch) 2021-03-10 07:06 PST, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (20.09 KB, patch) 2021-03-10 07:09 PST, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (29.69 KB, patch) 2021-03-10 07:27 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (25) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2020-04-22 18:51:41 PDT Comment hidden (obsolete)

Created attachment 397300 [details] WIP Patch

Don Olmstead

Comment 2 2020-04-22 19:13:37 PDT Comment hidden (obsolete)

Created attachment 397301 [details] WIP Patch

Don Olmstead

Comment 3 2021-03-02 08:03:00 PST Comment hidden (obsolete)

Created attachment 421934 [details] WIP Patch

Don Olmstead

Comment 4 2021-03-02 08:07:06 PST Comment hidden (obsolete)

Created attachment 421936 [details] WIP Patch

Don Olmstead

Comment 5 2021-03-02 08:21:23 PST Comment hidden (obsolete)

Created attachment 421939 [details] WIP Patch

Don Olmstead

Comment 6 2021-03-02 08:26:59 PST Comment hidden (obsolete)

Created attachment 421941 [details] WIP Patch

Don Olmstead

Comment 7 2021-03-02 08:42:54 PST Comment hidden (obsolete)

Created attachment 421944 [details] WIP Patch

Don Olmstead

Comment 8 2021-03-02 09:22:25 PST Comment hidden (obsolete)

Created attachment 421949 [details] WIP Patch

Don Olmstead

Comment 9 2021-03-02 09:55:21 PST Comment hidden (obsolete)

Created attachment 421955 [details] WIP Patch

Don Olmstead

Comment 10 2021-03-02 10:09:41 PST Comment hidden (obsolete)

Created attachment 421959 [details] WIP Patch

Don Olmstead

Comment 11 2021-03-02 11:02:31 PST Comment hidden (obsolete)

Created attachment 421966 [details] WIP Patch

EWS Watchlist

Comment 12 2021-03-02 11:03:15 PST Comment hidden (obsolete)

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Don Olmstead

Comment 13 2021-03-02 11:19:40 PST Comment hidden (obsolete)

Created attachment 421967 [details] WIP Patch

Don Olmstead

Comment 14 2021-03-02 11:34:12 PST Comment hidden (obsolete)

Created attachment 421969 [details] WIP Patch

Don Olmstead

Comment 15 2021-03-02 11:38:52 PST Comment hidden (obsolete)

Created attachment 421971 [details] WIP Patch

Don Olmstead

Comment 16 2021-03-02 11:49:22 PST Comment hidden (obsolete)

Created attachment 421972 [details] WIP Patch