Bug 210860

Summary: [JSC] JSBigInt inc operation does not produce right HeapBigInt zero
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2020-04-22 08:56:27 PDT 
I've crafted the custom build of JSC, and found this.
Looking.
Comment 1 Yusuke Suzuki 2020-04-22 08:57:04 PDT 
--useJIT=0 fails. This is C++ runtime bug.
Comment 2 Yusuke Suzuki 2020-04-22 08:57:11 PDT 
(In reply to Yusuke Suzuki from comment #1)
> --useJIT=0 fails. This is C++ runtime bug.

Or LLInt.
Comment 3 Yusuke Suzuki 2020-04-22 09:24:42 PDT 
Created attachment 397204 [details]
Patch
Comment 4 Mark Lam 2020-04-22 09:29:10 PDT 
Comment on attachment 397204 [details]
Patch

r=me
Comment 5 Robin Morisset 2020-04-22 10:03:37 PDT 
Comment on attachment 397204 [details]
Patch

good catch. r=me as well.
Comment 6 Yusuke Suzuki 2020-04-22 11:06:47 PDT 
EWS gets green (failures are known ones). Landing.
Comment 7 Yusuke Suzuki 2020-04-22 11:12:44 PDT 
Committed r260522: <https://trac.webkit.org/changeset/260522>
Comment 8 Radar WebKit Bug Importer 2020-04-22 11:13:16 PDT 
<rdar://problem/62197537>
Comment 9 Saam Barati 2020-04-22 12:38:47 PDT 
Comment on attachment 397204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397204&action=review

> Source/JavaScriptCore/runtime/JSCJSValue.cpp:315
> +            out.print("BigInt[heap-allocated]: addr=", RawPointer(asCell()), ", length=", jsCast<JSBigInt*>(asCell())->length(), ", sign=", jsCast<JSBigInt*>(asCell())->sign());

nice. Maybe we could also just toString this?
Comment 10 Yusuke Suzuki 2020-04-22 17:12:41 PDT 
Comment on attachment 397204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397204&action=review

>> Source/JavaScriptCore/runtime/JSCJSValue.cpp:315
>> +            out.print("BigInt[heap-allocated]: addr=", RawPointer(asCell()), ", length=", jsCast<JSBigInt*>(asCell())->length(), ", sign=", jsCast<JSBigInt*>(asCell())->sign());
> 
> nice. Maybe we could also just toString this?

Sounds good. Let's extend it!