| Summary: | [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, annulen, ap, benjamin, cdumez, cmarcelo, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jiewen_tan, keith_miller, kondapallykalyan, mark.lam, msaboff, pdr, ross.kirsling, ryuan.choi, saam, sabouhallawa, schenney, sergio, toyoshim, tzagallo, webkit-bug-importer, yutak | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=210812 https://bugs.webkit.org/show_bug.cgi?id=209694 |
||||||||||
| Bug Depends on: | 209694 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Darin Adler
2020-04-21 21:55:29 PDT
Created attachment 397168 [details]
Patch
Almost ready to go. The only remaining problem is that there is a failure with Apple's internal installhdrs mechanism; will definitely need to fix that before landing. Created attachment 397257 [details]
Patch
New patch has everything needed now. This includes more than Anders reviewed, but I took the liberty of still leaving his name in as reviewer. Waiting for feedback before I land it. I was 30 seconds too late to complain about not undoing the StringConcatenate.cpp test workaround in this patch... (In reply to Alexey Proskuryakov from comment #5) > I was 30 seconds too late to complain about not undoing the > StringConcatenate.cpp test workaround in this patch... (For what it's worth, I had fixed that locally less than 30 seconds after posting the first one.) Created attachment 397261 [details]
Patch
Comment on attachment 397261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397261&action=review > Tools/ChangeLog:7 > +2020-04-22 Darin Adler <darin@apple.com> > + > + [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK > + https://bugs.webkit.org/show_bug.cgi?id=210845 > + > + Reviewed by NOBODY (OOPS!). > + I’ll fix this before landing. If I don’t get any more comments in the next couple of hours, I’ll land this. Committed r260554: <https://trac.webkit.org/changeset/260554> |