Bug 210834

Summary: JSC's options should be case insensitive
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Keith Miller 2020-04-21 17:46:54 PDT 
JSC's options should be case insensitive
Comment 1 Keith Miller 2020-04-21 17:47:22 PDT 
Created attachment 397152 [details]
Patch
Comment 2 Keith Miller 2020-04-21 17:50:14 PDT 
Created attachment 397154 [details]
Patch
Comment 3 Yusuke Suzuki 2020-04-21 17:52:00 PDT 
Comment on attachment 397154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397154&action=review

r=me

> Source/JavaScriptCore/runtime/OptionsList.h:-544
> -    v(verboseDFGByteCodeParsing, verboseDFGBytecodeParsing, SameOption) \

Fun!
Comment 4 Mark Lam 2020-04-21 18:04:37 PDT 
Nice.  r=me too.
Comment 5 EWS 2020-04-21 18:27:53 PDT 
Committed r260481: <https://trac.webkit.org/changeset/260481>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397154 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-21 18:28:15 PDT 
<rdar://problem/62144198>
Comment 7 Ryan Haddad 2020-04-21 20:55:08 PDT 
(In reply to EWS from comment #5)
> Committed r260481: <https://trac.webkit.org/changeset/260481>
As EWS predicted, this broke the Windows build:
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\JavaScriptCore\runtime/Options.cpp(791,5): error C3861: 'strncasecmp': identifier not found (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f2e18ffc-28.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj]
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\JavaScriptCore\runtime/Options.cpp(834,5): error C3861: 'strncasecmp': identifier not found (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f2e18ffc-28.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj]
Comment 8 Yusuke Suzuki 2020-04-21 21:07:50 PDT 
Committed r260499: <https://trac.webkit.org/changeset/260499>
Comment 9 Yusuke Suzuki 2020-04-21 21:12:06 PDT 
Committed r260500: <https://trac.webkit.org/changeset/260500>