Bug 210796

Summary:	[GTK] Several resourceLoadStatistics tests are failing
Product:	WebKit	Reporter:	Diego Pino <dpino>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	cgarcia, lmoura
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=210184 https://bugs.webkit.org/show_bug.cgi?id=194629

Description Diego Pino 2020-04-21 07:55:35 PDT

The following tests started failing after r260356:

http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour-database.html [ Timeout ]
http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html [ Failure ]
http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-database.html [ Failure ]
http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion.html [ Failure ]

See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r260356%20(13404)/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-diff.txt

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-actual.txt
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: WebSocket connection to 'ws://localhost/' failed: Unexpected response code: 200
+CONSOLE MESSAGE: The server did not accept the WebSocket handshake.
 Construct a cross-site WebSocket in a frame with server-side refusal. The test passes if Resource Load Statistics logs it properly.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r260356%20(13404)/http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-database-diff.txt

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-database-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-database-actual.txt
@@ -6,10 +6,8 @@
 Before deletion: LocalStorage entry does exist.
 Before deletion: IDB entry does exist.
 
-After deletion: HttpOnly cookie exists.
-After deletion: Client-side cookie exists.
-After deletion: Regular server-side cookie exists.
-After deletion: LocalStorage entry does exist.
+After script-accessible deletion: No cookies found.
+After deletion: LocalStorage entry does not exist.
 After deletion: IDB entry does exist.

See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r260356%20(13404)/http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-diff.txt

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion-actual.txt
@@ -6,10 +6,8 @@
 Before deletion: LocalStorage entry does exist.
 Before deletion: IDB entry does exist.
 
-After deletion: HttpOnly cookie exists.
-After deletion: Client-side cookie exists.
-After deletion: Regular server-side cookie exists.
-After deletion: LocalStorage entry does exist.
+After script-accessible deletion: No cookies found.
+After deletion: LocalStorage entry does not exist.
 After deletion: IDB entry does exist.

Comment 1 Carlos Garcia Campos 2020-04-22 02:30:17 PDT

These are not regressions, since they were skipped before. I'll check them, I think they all passed for me locally.

Comment 2 Lauro Moura 2020-04-22 04:57:14 PDT

(In reply to Diego Pino from comment #0)
> The following tests started failing after r260356:
> 
> http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.
> html [ Failure ]

snip.

> See:
> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/
> r260356%20(13404)/http/tests/websocket/connection-refusal-in-frame-resource-
> load-statistics-diff.txt
> 
> ---
> /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/
> http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-
> expected.txt
> +++
> /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/
> http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-
> actual.txt
> @@ -1,4 +1,4 @@
> -CONSOLE MESSAGE: WebSocket connection to 'ws://localhost/' failed:
> Unexpected response code: 200
> +CONSOLE MESSAGE: The server did not accept the WebSocket handshake.
>  Construct a cross-site WebSocket in a frame with server-side refusal. The
> test passes if Resource Load Statistics logs it properly.
>  
>  On success, you will see a series of "PASS" messages, followed by "TEST
> COMPLETE".

This one was due to an obsolete console message. Rebaselined in bug194629 / r260495

Comment 3 Diego Pino 2020-05-08 00:09:46 PDT

http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour-database.html has been a timeout flaky since:

[r260716-r260717]             TIMEOUT (Expected: TIMEOUT)
r260718                       UNKNOWN
r260719                       PASS (Expected: TIMEOUT)