| Summary: | [Win] Use generic WorkQueue instead of WorkQueueWin.cpp | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
| Component: | Web Template Framework | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, benjamin, cdumez, cmarcelo, darin, don.olmstead, ews-watchlist, gyuyoung.kim, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=186455 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Fujii Hironori
2020-04-20 23:20:26 PDT
Created attachment 397056 [details]
WIP patch
WorkQueueWin is using random threads to executing dispatched functions. This is not desired for IPC::Connection because it need to call CancelIo API in the thread started aync ReadFile operations. (Bug 209847 Comment 25) Created attachment 397120 [details]
Patch
Comment on attachment 397120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397120&action=review > Source/WTF/wtf/WorkQueue.h:35 > -#if USE(COCOA_EVENT_LOOP) > +#if PLATFORM(COCOA) Why is this a good change? Our overall plan is to eventually cut PLATFORM(XXX) down to an absolute minimum. Seems sad to move in the other direction. Comment on attachment 397120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397120&action=review Thank you for the review. >> Source/WTF/wtf/WorkQueue.h:35 >> +#if PLATFORM(COCOA) > > Why is this a good change? Our overall plan is to eventually cut PLATFORM(XXX) down to an absolute minimum. Seems sad to move in the other direction. Agreed. Will fix. I think USE_*_EVENT_LOOP macros should be refined. But it is another topic. Created attachment 397139 [details]
Patch for landing
Comment on attachment 397139 [details] Patch for landing Clearing flags on attachment: 397139 Committed r260477: <https://trac.webkit.org/changeset/260477> All reviewed patches have been landed. Closing bug. |