Bug 210765

Summary: Add more structure-cloning tests for BigInt
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, ews-watchlist, jsbell, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch mark.lam: review+

Description Yusuke Suzuki 2020-04-20 13:40:09 PDT
We should have tests outside of WPT too.
Comment 1 Yusuke Suzuki 2020-04-20 14:00:06 PDT
Created attachment 397011 [details]
WIP

Patch for collecting expect files from GTK etc.
Comment 2 Yusuke Suzuki 2020-04-20 14:15:03 PDT
(In reply to Yusuke Suzuki from comment #1)
> Created attachment 397011 [details]
> WIP
> 
> Patch for collecting expect files from GTK etc.

Ugh, GTK is not running tests in EWS.
Comment 3 Yusuke Suzuki 2020-04-20 14:28:42 PDT
Created attachment 397017 [details]
Patch
Comment 4 Yusuke Suzuki 2020-04-20 14:34:27 PDT
Created attachment 397018 [details]
Patch
Comment 5 Mark Lam 2020-04-20 14:40:08 PDT
Comment on attachment 397018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397018&action=review

r=me

> LayoutTests/fast/dom/Window/window-postmessage-clone.html:327
> +        'var i = Object(100000000000000000000n); ' +

There’s a comment above this that should be updated to include BigInt too.
Comment 6 Yusuke Suzuki 2020-04-20 14:40:30 PDT
Comment on attachment 397018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397018&action=review

Thanks!

>> LayoutTests/fast/dom/Window/window-postmessage-clone.html:327
>> +        'var i = Object(100000000000000000000n); ' +
> 
> There’s a comment above this that should be updated to include BigInt too.

Fixed.
Comment 7 Yusuke Suzuki 2020-04-20 15:26:29 PDT
WK1 EWS is green and seems that this test is skipped in wk2. Landing.
Comment 8 Yusuke Suzuki 2020-04-20 15:33:06 PDT
Committed r260404: <https://trac.webkit.org/changeset/260404>
Comment 9 Radar WebKit Bug Importer 2020-04-20 15:34:14 PDT
<rdar://problem/62079013>