Bug 210748

Summary:

[Clang 10] Fix warning: definition of implicit copy assignment operator for 'PageBlock' is deprecated because it has a user-declared copy constructor

Product:

WebKit

Reporter:

Charlie Turner <cturner>

Component:

WebKitGTK

Assignee:

Charlie Turner <cturner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, benjamin, bugs-noreply, cdumez, cmarcelo, darin, ews-watchlist

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Charlie Turner 2020-04-20 08:22:39 PDT

This warning was spamming the build process a lot.

Comment 1 Charlie Turner 2020-04-20 10:43:33 PDT

Created attachment 396990 [details]
Patch

Comment 2 Adrian Perez 2020-04-21 04:21:37 PDT

Patch LGTM, I am tempted to r+ given that all the EWS builders
are green, but would be more confident if someone else would also
take a quick look as this is fairly low-level code 🤔️

Comment 3 Adrian Perez 2020-04-21 04:28:37 PDT

Comment on attachment 396990 [details]
Patch

Let's wait until tomorrow to land this in case someone else wants to take a
look, but the more I stare at it, the more I am convinced it's all right :D

Comment 4 Darin Adler 2020-04-21 08:57:00 PDT

Looks right to me.

Comment 5 EWS 2020-04-21 09:21:35 PDT

Committed r260431: <https://trac.webkit.org/changeset/260431>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396990 [details].