| Summary: | [JSC] SlowPathCall is not supported by callOperation in Windows | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-04-19 18:13:04 PDT
Created attachment 396932 [details]
Patch
Comment on attachment 396932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396932&action=review > Source/JavaScriptCore/jit/SlowPathCall.h:68 > + static_assert(JIT::regT0 == GPRInfo::returnValueGPR); > + static_assert(JIT::regT1 == GPRInfo::returnValueGPR2); Should we update this instead? https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/jit/GPRInfo.h#L796-L799 Comment on attachment 396932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396932&action=review >> Source/JavaScriptCore/jit/SlowPathCall.h:68 >> + static_assert(JIT::regT1 == GPRInfo::returnValueGPR2); > > Should we update this instead? > https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/jit/GPRInfo.h#L796-L799 For non-Windows x64, returnValueGPR2 is not regT1. We are using this static_assert only inside `OS(WINDOWS)`. Committed r260346: <https://trac.webkit.org/changeset/260346> |