Bug 210692

Summary: Overflow scrollbars don't grow when hovered
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cmarcelo, ews-watchlist, fred.wang, gyuyoung.kim, jamesr, luiz, ryuan.choi, sergio, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch
none
Patch
none
Patch none

Description Simon Fraser (smfr) 2020-04-18 11:08:15 PDT
Overlay scrollbars should grow when hovered. This works for main frame scrollbars, but not overflow scrollbars.
Comment 1 Radar WebKit Bug Importer 2020-04-18 11:08:30 PDT
<rdar://problem/61977273>
Comment 2 Simon Fraser (smfr) 2020-05-04 13:46:07 PDT
Created attachment 398406 [details]
Patch
Comment 3 Tim Horton 2020-05-04 13:50:25 PDT
Comment on attachment 398406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398406&action=review

> Source/WebCore/platform/PlatformWheelEvent.h:159
> +    bool isGestureStart() const;

This name seems like it's going to make someone sad someday. 'mayBegin' does not a 'start' make.
Comment 4 Simon Fraser (smfr) 2020-05-04 15:02:03 PDT
Created attachment 398421 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-05-04 15:08:34 PDT
Created attachment 398423 [details]
Patch
Comment 6 Simon Fraser (smfr) 2020-05-04 15:50:12 PDT
Created attachment 398427 [details]
Patch
Comment 7 EWS 2020-05-04 17:59:12 PDT
Committed r261132: <https://trac.webkit.org/changeset/261132>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398427 [details].