Bug 210662

Summary: Bring Fullscreen API + alert() behavior from iOS to macOS
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, jberlin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210676
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Jer Noble
Reported 2020-04-17 11:20:12 PDT
Bring Fullscreen API + alert() behavior from iOS to macOS
Attachments
Patch (2.79 KB, patch)
2020-04-17 11:23 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (10.43 KB, patch)
2020-04-17 12:07 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-04-17 11:23:44 PDT
Created attachment 396777 [details] Patch
Darin Adler
Comment 2 2020-04-17 11:24:58 PDT
Comment on attachment 396777 [details] Patch Regression test?
Jer Noble
Comment 3 2020-04-17 11:35:43 PDT
We should be able to write an API test for both macOS and iOS verifying that we exit fullscreen mode when the page fires an alert(). Will add before landing.
Jer Noble
Comment 4 2020-04-17 12:07:53 PDT
Created attachment 396779 [details] Patch for landing
Jer Noble
Comment 5 2020-04-17 12:44:20 PDT
<rdar://problem/60684195>
EWS
Comment 6 2020-04-17 13:41:15 PDT
Committed r260278: <https://trac.webkit.org/changeset/260278> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396779 [details].
Note You need to log in before you can comment on or make changes to this bug.