Bug 210632

Summary:

[WebGL] Confirm there are no errors when setting up framebuffers

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

WebGL

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, noam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Dean Jackson 2020-04-16 19:42:35 PDT

We're seeing crashes on macOS inside GraphicsContextGL::reshape(). Specifically when we submit work at the end of the function via glFlush.

At the moment the cause is a mystery, because we should bail out before then if the multisample renderbuffer was not complete. In the hope that it helps somewhat, add a call to glGetError to double check that there isn't anything horribly wrong before we talk to the GPU.

Comment 1 Radar WebKit Bug Importer 2020-04-16 19:42:48 PDT

<rdar://problem/61916680>

Comment 2 Dean Jackson 2020-04-17 15:56:06 PDT

Created attachment 396812 [details]
Patch

Comment 3 Dean Jackson 2020-04-17 16:31:18 PDT

Committed r260301: <https://trac.webkit.org/changeset/260301>