Bug 210533

Summary: SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210825    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2020-04-14 23:18:42 PDT 
SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
Comment 1 Alex Christensen 2020-04-14 23:19:52 PDT 
Created attachment 396504 [details]
Patch
Comment 2 EWS 2020-04-20 19:29:11 PDT 
Tools/Scripts/svn-apply failed to apply attachment 396504 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 3 Alex Christensen 2020-04-20 19:36:26 PDT 
Created attachment 397047 [details]
Patch
Comment 4 EWS 2020-04-20 20:23:58 PDT 
Committed r260410: <https://trac.webkit.org/changeset/260410>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397047 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-20 20:25:28 PDT 
<rdar://problem/62088873>
Comment 6 Ryan Haddad 2020-04-21 20:58:41 PDT 
Reverted r260410 for reason:

Caused crashes in Safari

Committed r260497: <https://trac.webkit.org/changeset/260497>
Comment 7 Ryan Haddad 2020-04-21 20:59:33 PDT 
(In reply to Ryan Haddad from comment #6)
> Reverted r260410 for reason:
> 
> Caused crashes in Safari
> 
> Committed r260497: <https://trac.webkit.org/changeset/260497>
Reverted because I had to had to revert https://bugs.webkit.org/show_bug.cgi?id=210825, which was a follow-up fix for this change.
Comment 8 Alex Christensen 2020-04-24 10:36:05 PDT 
Comment on attachment 397047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397047&action=review

> Source/WebKit/NetworkProcess/NetworkLoad.cpp:291
> +    m_networkProcess->send(Messages::NetworkProcessProxy::DidNegotiateModernTLS(m_parameters.webPageProxyID, challenge));

I'm adding if (m_parameters.webPageProxyID) here.  We should later make sure that's always true.
Comment 9 Alex Christensen 2020-04-24 10:38:05 PDT 
Created attachment 397469 [details]
Patch
Comment 10 EWS 2020-04-24 11:23:48 PDT 
Committed r260658: <https://trac.webkit.org/changeset/260658>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397469 [details].