Bug 210515

Summary:	REGRESSION(r260062): [GTK] Three SVG tests are failing
Product:	WebKit	Reporter:	Diego Pino <dpino>
Component:	SVG	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	lmoura, webkit-bug-importer, zimmermann
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=210282

Description Diego Pino 2020-04-14 14:12:51 PDT

After r260062 3 SVG tests started failing:

   svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg [ Failure ]
   svg/W3C-SVG-1.1-SE/types-dom-05-b.svg [ Failure ]
   svg/custom/glyph-transformation-with-hkern.svg [ Failure ]

Diff: 

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/W3C-SVG-1.1-SE/text-tspan-02-b-actual.txt
@@ -15,10 +15,10 @@
           chunk 1 text run 7 at (110.72,120.00) startOffset 6 endOffset 7 width 8.00: "l"
           chunk 1 text run 8 at (118.72,120.00) startOffset 7 endOffset 8 width 10.00: " "
           chunk 1 text run 9 at (128.72,120.00) startOffset 8 endOffset 9 width 18.00: "c"
-          chunk 1 text run 10 at (146.72,120.00) startOffset 9 endOffset 10 width 19.03: "h"
-          chunk 1 text run 11 at (165.75,120.00) startOffset 10 endOffset 11 width 19.00: "a"
-          chunk 1 text run 12 at (184.75,120.00) startOffset 11 endOffset 12 width 12.00: "r"
-          chunk 1 text run 13 at (196.75,120.00) startOffset 12 endOffset 13 width 18.82: "a"
+          chunk 1 text run 10 at (146.72,120.00) startOffset 9 endOffset 10 width 19.04: "h"
+          chunk 1 text run 11 at (165.76,120.00) startOffset 10 endOffset 11 width 19.00: "a"
+          chunk 1 text run 12 at (184.76,120.00) startOffset 11 endOffset 12 width 12.00: "r"
+          chunk 1 text run 13 at (196.76,120.00) startOffset 12 endOffset 13 width 18.82: "a"
           chunk 1 text run 14 at (215.58,120.00) startOffset 13 endOffset 14 width 18.00: "c"
           chunk 1 text run 15 at (233.58,120.00) startOffset 14 endOffset 15 width 10.00: "t"
           chunk 1 text run 16 at (243.58,120.00) startOffset 15 endOffset 16 width 18.51: "e"
@@ -78,10 +78,10 @@
             chunk 1 text run 3 at (110.72,120.00) startOffset 2 endOffset 3 width 8.00: "l"
             chunk 1 text run 4 at (118.72,120.00) startOffset 3 endOffset 4 width 10.00: " "
             chunk 1 text run 5 at (128.72,120.00) startOffset 4 endOffset 5 width 18.00: "c"
-            chunk 1 text run 6 at (146.72,120.00) startOffset 5 endOffset 6 width 19.03: "h"
-            chunk 1 text run 7 at (165.75,120.00) startOffset 6 endOffset 7 width 19.00: "a"
-            chunk 1 text run 8 at (184.75,120.00) startOffset 7 endOffset 8 width 12.00: "r"
-            chunk 1 text run 9 at (196.75,120.00) startOffset 8 endOffset 9 width 18.82: "a"
+            chunk 1 text run 6 at (146.72,120.00) startOffset 5 endOffset 6 width 19.04: "h"
+            chunk 1 text run 7 at (165.76,120.00) startOffset 6 endOffset 7 width 19.00: "a"
+            chunk 1 text run 8 at (184.76,120.00) startOffset 7 endOffset 8 width 12.00: "r"
+            chunk 1 text run 9 at (196.76,120.00) startOffset 8 endOffset 9 width 18.82: "a"
             chunk 1 text run 10 at (215.58,120.00) startOffset 9 endOffset 10 width 18.00: "c"
             chunk 1 text run 11 at (233.58,120.00) startOffset 10 endOffset 11 width 10.00: "t"
             chunk 1 text run 12 at (243.58,120.00) startOffset 11 endOffset 12 width 18.51: "e"
@@ -96,9 +96,9 @@
             RenderSVGTSpan {tspan} at (0,0) size 68x44
               RenderSVGInlineText {#text} at (332,6) size 68x44
                 chunk 1 text run 1 at (339.23,120.00) startOffset 0 endOffset 1 width 10.00: "t"
-                chunk 1 text run 2 at (349.23,120.00) startOffset 1 endOffset 2 width 18.89: "h"
-                chunk 1 text run 3 at (368.12,120.00) startOffset 2 endOffset 3 width 19.00: "e"
-                chunk 1 text run 4 at (387.12,120.00) startOffset 3 endOffset 4 width 10.00: " "
+                chunk 1 text run 2 at (349.23,120.00) startOffset 1 endOffset 2 width 18.90: "h"
+                chunk 1 text run 3 at (368.13,120.00) startOffset 2 endOffset 3 width 19.00: "e"
+                chunk 1 text run 4 at (387.13,120.00) startOffset 3 endOffset 4 width 10.00: " "
             RenderSVGInlineText {#text} at (0,0) size 0x0
           RenderSVGInlineText {#text} at (0,0) size 0x0
           RenderSVGTSpan {tspan} at (0,0) size 86x40

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/W3C-SVG-1.1-SE/types-dom-05-b-actual.txt
@@ -20,7 +20,7 @@
             chunk 1 text run 1 at (50.00,100.00) startOffset 0 endOffset 27 width 180.20: "Invalid string on SVGLength"
         RenderSVGText {text} at (50,128) size 163x15 contains 1 chunk(s)
           RenderSVGInlineText {#text} at (0,0) size 163x15
-            chunk 1 text run 1 at (50.00,140.00) startOffset 0 endOffset 24 width 162.73: "Valid string on SVGAngle"
+            chunk 1 text run 1 at (50.00,140.00) startOffset 0 endOffset 24 width 162.74: "Valid string on SVGAngle"
         RenderSVGText {text} at (50,168) size 174x15 contains 1 chunk(s)
           RenderSVGInlineText {#text} at (0,0) size 174x15
             chunk 1 text run 1 at (50.00,180.00) startOffset 0 endOffset 26 width 173.15: "Invalid string on SVGAngle"

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/custom/glyph-transformation-with-hkern-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/custom/glyph-transformation-with-hkern-actual.txt
@@ -8,6 +8,6 @@
         chunk 1 text run 1 at (30.00,30.00) startOffset 0 endOffset 1 width 25.00: "R"
         chunk 1 text run 1 at (50.00,50.00) startOffset 0 endOffset 1 width 26.54: "O"
         chunk 1 text run 1 at (70.00,70.00) startOffset 0 endOffset 1 width 19.53: "T"
-        chunk 1 text run 1 at (90.00,90.00) startOffset 0 endOffset 1 width 19.67: "A"
+        chunk 1 text run 1 at (90.00,90.00) startOffset 0 endOffset 1 width 19.68: "A"
         chunk 1 text run 1 at (110.00,110.00) startOffset 0 endOffset 1 width 17.74: "T"
         chunk 1 text run 1 at (130.00,130.00) startOffset 0 endOffset 1 width 23.00: "E"

Comment 1 Lauro Moura 2020-04-14 15:23:47 PDT

I managed to reproduce it locally with jhbuild, but not with flatpak (they are passing). Maybe related to different harfbuzz version or something like that (2.2.0 in jhbuild while the flatpak SDK provides 2.6.2).

They should be working after migrating to flatpak.

Comment 2 Diego Pino 2020-05-06 06:36:44 PDT

That's correct, these test have been passing since the test bots switched to Flatpak. The failures have been removed from either GTK and WPE test expectations https://trac.webkit.org/changeset/261222/webkit

Comment 3 Radar WebKit Bug Importer 2020-05-06 06:37:14 PDT

<rdar://problem/62928474>