Bug 210504

Summary: Add bundle SPI to call WebPage::setTopContentInset
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: NEW ---    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review-

Description Alex Christensen 2020-04-14 11:20:32 PDT
Add bundle SPI to call WebPage::setTopContentInset
Comment 1 Alex Christensen 2020-04-14 11:21:23 PDT
Created attachment 396442 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-04-14 11:21:50 PDT
<rdar://problem/61781406>
Comment 3 Simon Fraser (smfr) 2020-04-14 11:50:14 PDT
Comment on attachment 396442 [details]
Patch

Please explain how this interacts with WebViewImpl::updateContentInsetsIfAutomatic() - m_automaticallyAdjustsContentInsets is on by default in WKWebView. That's called from WebViewImpl::renewGStateI(), which is called whenever AppKit jiggles the view hierarchy, which is a lot.
Comment 4 Alex Christensen 2020-04-14 13:04:14 PDT
When this is called we could also send a message to the WebPageProxy to update it.  Would that resolve your concerns?
Comment 5 Tim Horton 2020-04-14 13:07:40 PDT
What does it /mean/, though? Does automaticallyAdjustsContentInsets become NO, too? It's all very weird.

But definitely the UIProcess needs to know when it changes, yes.