Bug 210470

Summary: REGRESSION (r259587): bterlson/eshost throws during init in strict mode
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: Tools / TestsAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Minor CC: darin, ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=187526
Attachments:
Description Flags
Patch none

Description Alexey Shvayka 2020-04-13 18:18:50 PDT 
bterlson/eshost is used by bterlson/test262-harness, which is used by https://test262.report.
As of r259587, JSC fails all tests in strict mode.
During init, bterlson/eshost does `$262.IsHTMLDDA = function() {...}`, which causes TypeError because "IsHTMLDDA" property has no setter.
Comment 1 Alexey Shvayka 2020-04-13 18:33:18 PDT 
Created attachment 396369 [details]
Patch
Comment 2 Ross Kirsling 2020-04-13 18:54:44 PDT 
Comment on attachment 396369 [details]
Patch

Holy cow, good work. I was having a hell of a time trying to track down where this was coming from myself.
Comment 3 EWS 2020-04-13 20:05:27 PDT 
Committed r260057: <https://trac.webkit.org/changeset/260057>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396369 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-13 20:06:14 PDT 
<rdar://problem/61752521>