Bug 210442

Summary:

REGRESSION (r259900) : Speedometer failing on Catalina-Release-WK2-Perf bot

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, ews-watchlist, glenn, hi, jbedard, rniwa, slewis, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Ryan Haddad 2020-04-13 11:20:03 PDT

Speedometer is failing on Catalina-Release-WK2-Perf bot as or r259905 due to spurious(?) console logging:

Running Speedometer (202 of 203)
ERROR: CONSOLE MESSAGE: DEBUG: -------------------------------
FAILED
Finished: 37.682425 s

https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Perf/builds/660/steps/perf-test/logs/stdio

Comment 1 Radar WebKit Bug Importer 2020-04-13 11:20:18 PDT

<rdar://problem/61727169>

Comment 2 Alexey Proskuryakov 2020-04-13 17:28:50 PDT

This code in perftest.py needs to be updated after line number removal:

    _lines_to_ignore = [
        re.compile("^\s+$"),
        # Following are for handle existing test like Dromaeo
        re.compile(re.escape("""main frame - has 1 onunload handler(s)""")),
        re.compile('frame \"[^"]+\" - has \d+ onunload handler\(s\)'),
        # Following is for html5.html
        re.compile(re.escape("""Blocked access to external URL http://www.whatwg.org/specs/web-apps/current-work/""")),
        re.compile(r"CONSOLE MESSAGE: (line \d+: )?Blocked script execution in '[A-Za-z0-9\-\.:]+' because the document's frame is sandboxed and the 'allow-scripts' permission is not set."),
        re.compile(r"CONSOLE MESSAGE: (line \d+: )?Not allowed to load local resource"),
        # Speedometer 2.0
        re.compile(r'CONSOLE MESSAGE: line \d+: DEBUG: -------------------------------'),
        re.compile(r'CONSOLE MESSAGE: line \d+: DEBUG: Ember\s+: (\d\.)+'),
        re.compile(r'CONSOLE MESSAGE: line \d+: DEBUG: jQuery\s+: (\d\.)+'),
    ]

Comment 3 Devin Rousso 2020-04-13 17:33:32 PDT

Created attachment 396363 [details]
Patch

Comment 4 Stephanie Lewis 2020-04-13 17:38:07 PDT

Comment on attachment 396363 [details]
Patch

Looks fine to me as long as still runs on older builds.

Comment 5 Devin Rousso 2020-04-13 17:47:28 PDT

Created attachment 396365 [details]
Patch

ensure backwards compatibility

Comment 6 EWS 2020-04-13 18:30:04 PDT

Committed r260053: <https://trac.webkit.org/changeset/260053>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396365 [details].