Bug 210423

Summary: Add WARN_UNUSED_RETURN to decode methods in Source/WebKit
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, cgarcia, darin, eric.carlson, ews-watchlist, glenn, hta, jbedard, jer.noble, philipj, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-04-13 07:37:33 PDT
Add WARN_UNUSED_RETURN to decode methods in Source/WebKit. Found via: $ ./Tools/Scripts/check-webkit-style --filter=-,+security/missing_warn_unused_return Source/WebKit NOTE: Not every change is relate to CoreIPC decoding, but they're all decode methods that return bool. Also found a couple platformDecode() methods, so will update check-webkit-style.
Attachments
Patch v1 (61.72 KB, patch)
2020-04-13 07:44 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-04-13 07:37:54 PDT
<rdar://problem/61715582>
David Kilzer (:ddkilzer)
Comment 2 2020-04-13 07:38:52 PDT
Note: No issues were found. This is to add WARN_UNUSED_RETURN to decode methods returning `bool` to prevent future bugs.
David Kilzer (:ddkilzer)
Comment 3 2020-04-13 07:44:43 PDT
Created attachment 396273 [details] Patch v1
EWS
Comment 4 2020-04-13 10:48:28 PDT
Committed r260025: <https://trac.webkit.org/changeset/260025> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396273 [details].
Note You need to log in before you can comment on or make changes to this bug.