| Summary: | KeyedDecoder functions in ResourceLoadStatistics.{cpp,h} should return bool and use WARN_UNUSED_RETURN | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
| Component: | WebCore Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
| Status: | RESOLVED INVALID | ||||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, cdumez, darin, ews-watchlist, japhet, katherine_cheney, webkit-bug-importer, wilander, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 212422, 212424 | ||||||||||
| Bug Blocks: | 210416, 212423 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 396250 [details]
Patch v1
Committed r260023: <https://trac.webkit.org/changeset/260023> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396250 [details]. Re-opened since this is blocked by bug 212422 Created attachment 400368 [details]
Patch v2
The content of attachment 400368 [details] has been deleted for the following reason: Uploaded to wrong bug (was for Bug 212424). This will be fixed a different way in the future. Reopening to attach new patch. Created attachment 400393 [details]
Patch v4
The content of attachment 400393 [details] has been deleted for the following reason: Uploaded to wrong bug (was for Bug 212424). |
KeyedDecoder functions in ResourceLoadStatistics.{cpp,h} should return bool and use WARN_UNUSED_RETURN. Found via: $ ./Tools/Scripts/check-webkit-style --filter=-,+security/missing_warn_unused_return Source/WebCore/loader/ResourceLoadStatistics.*