| Summary: | Make WTR::AccessibilityUIElements methods run on AX secondary thread. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cfleizach, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2020-04-11 14:44:02 PDT
Created attachment 396192 [details]
Patch
GTK failures. looks like we have things like id in the .h file
../../Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:57:12: error: ‘id’ does not name a type; did you mean ‘GPid’?
friend id attributeValue(id, NSString*);
^~
GPid
../../Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp:29:
../../Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:56:12: error: ‘NSArray’ does not name a type; did you mean ‘GArray’?
friend NSArray* supportedAttributes(id);
^~~~~~~
Created attachment 396269 [details]
Patch
(In reply to chris fleizach from comment #2) > GTK failures. looks like we have things like id in the .h file > > ../../Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:57:12: > error: ‘id’ does not name a type; did you mean ‘GPid’? > friend id attributeValue(id, NSString*); > ^~ > GPid > > ../../Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp:29: > ../../Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:56:12: > error: ‘NSArray’ does not name a type; did you mean ‘GArray’? > friend NSArray* supportedAttributes(id); > ^~~~~~~ Fixed in latest revision. Comment on attachment 396269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396269&action=review > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:194 > + for (NSUInteger i = 0; i < attributes.count; ++i) { can we just do for (NSString *attribute in attributes) { LGTM, but consider requests Committed r260029: <https://trac.webkit.org/changeset/260029> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396269 [details]. |