Bug 210367
| Summary: | JSC should have a failure string repository. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | keith_miller |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ross Kirsling
There are many places throughout our Intl API implementation in which ICU could have an internal failure.
JSC currently throws a JS error with a different message in each of these cases, but it might be better to have a single kind of error for all of them, like V8 and SM:
https://github.com/v8/v8/blob/master/src/common/message-template.h#L25
https://searchfox.org/mozilla-central/source/js/src/js.msg#536
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Keith Miller
Oh, I was thinking of having one repo of all our failure strings so they're consistent.
Ross Kirsling
Oh that's even more ambitious! I like it.