| Summary: | Add a timer to AVVideoCaptureSource to verify reception of frames | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=210285 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2020-04-10 08:16:03 PDT
Created attachment 396085 [details]
Patch
Created attachment 396087 [details]
Patch
Created attachment 396197 [details]
Patch
Comment on attachment 396197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396197&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:143 > + static constexpr Seconds verifyCaptureInterval = 3_s; Is three seconds long enough? > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:144 > + static const uint64_t framesToDropWhenStarting = 4; Shouldn't this be relative to the capture rate? > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:163 > + RELEASE_LOG_ERROR(WebRTC, "AVVideoCaptureSource::verifyIsCapturing - no frame received in %d seconds, failing", static_cast<int>(m_verifyCapturingTimer.repeatInterval().value())); > + captureFailed(); Failing capture completely is quite severe. Should we try to stop and restart the camera one time? (In reply to Eric Carlson from comment #4) > Comment on attachment 396197 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396197&action=review > > > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:143 > > + static constexpr Seconds verifyCaptureInterval = 3_s; > > Is three seconds long enough? I tried to pick something not too short but not too long either. Timer starts when session is running so frames should flow very quickly in theory. > > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:144 > > + static const uint64_t framesToDropWhenStarting = 4; > > Shouldn't this be relative to the capture rate? Might be the case. IIRC, from your testing, the first frames were bad, probably at 30 fps. I am guessing that we could reduce this number at lower frame rate. > > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:163 > > + RELEASE_LOG_ERROR(WebRTC, "AVVideoCaptureSource::verifyIsCapturing - no frame received in %d seconds, failing", static_cast<int>(m_verifyCapturingTimer.repeatInterval().value())); > > + captureFailed(); > > Failing capture completely is quite severe. Should we try to stop and > restart the camera one time? I was wondering the same thing and went this way following what we are doing for audio capture. At the same time, the application can always call getUserMedia if it wants to restart capture. Let's try that as a follow-up. Committed r260064: <https://trac.webkit.org/changeset/260064> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396197 [details]. |