Bug 210331

Summary: [EME][GStreamer] remove m_cdmInstance ASSERT in cdmInstanceDetached
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Charlie Turner 2020-04-10 03:41:16 PDT 
[EME][GStreamer] remove m_cdmInstance ASSERT in cdmInstanceDetached
Comment 1 Charlie Turner 2020-04-10 05:08:33 PDT 
Created attachment 396074 [details]
Patch
Comment 2 Charlie Turner 2020-04-10 07:40:13 PDT 
Created attachment 396081 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2020-04-10 08:10:16 PDT 
Comment on attachment 396081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396081&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-3788
> -    if (m_cdmInstance != &instance) {
> -        GST_WARNING("passed CDMInstance %p is different from stored one %p", &instance, m_cdmInstance.get());
> -        ASSERT_NOT_REACHED();
> -        return;
> -    }

I would still add this check inside the if, or even better, I would just bail out if (!m_cdmInstance).
Comment 4 Charlie Turner 2020-04-13 02:50:10 PDT 
Created attachment 396261 [details]
Patch
Comment 5 Charlie Turner 2020-04-13 02:52:16 PDT 
Created attachment 396262 [details]
Patch

Manually add the reviewer field
Comment 6 EWS 2020-04-13 03:18:33 PDT 
Committed r260001: <https://trac.webkit.org/changeset/260001>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396262 [details].