Bug 210322

Summary: Add WARN_UNUSED_RETURN to decode methods in WebCoreArgumentCoders
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, darin, ews-feeder, product-security, useafterfree, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2020-04-09 22:22:36 PDT 
Add WARN_UNUSED_RETURN to decode methods in WebCoreArgumentCoders.

No issues found.  This is to prevent future bugs from being introduced.
Comment 1 Radar WebKit Bug Importer 2020-04-09 22:22:47 PDT 
<rdar://problem/61565148>
Comment 2 David Kilzer (:ddkilzer) 2020-04-09 22:23:49 PDT 
Created attachment 396048 [details]
Patch v1
Comment 3 Darin Adler 2020-04-10 08:48:45 PDT 
Comment on attachment 396048 [details]
Patch v1

I see no reason to mark this bug security-sensitive.
Comment 4 David Kilzer (:ddkilzer) 2020-04-10 08:58:00 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 396048 [details]
> Patch v1
> 
> I see no reason to mark this bug security-sensitive.

It's a bit of a disinformation campaign.  I won't mark future ones as Security.
Comment 5 EWS 2020-04-10 09:03:46 PDT 
Committed r259875: <https://trac.webkit.org/changeset/259875>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396048 [details].
Comment 6 David Kilzer (:ddkilzer) 2020-04-11 16:57:34 PDT 
Follow-up fix:

Committed r259937: <https://trac.webkit.org/changeset/259937>