Bug 210318

Summary: Hit-testing a WebTiledBackingLayer with an animation asserts
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Simon Fraser (smfr) 2020-04-09 20:46:11 PDT 
Hit-testing a WebTiledBackingLayer with an animation asserts
Comment 1 Simon Fraser (smfr) 2020-04-09 20:47:58 PDT 
Created attachment 396040 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-04-09 20:48:22 PDT 
<rdar://problem/61561048>
Comment 3 Simon Fraser (smfr) 2020-04-09 20:56:32 PDT 
Created attachment 396041 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-04-09 21:02:02 PDT 
Created attachment 396042 [details]
Patch
Comment 5 EWS 2020-04-10 08:27:55 PDT 
Committed r259871: <https://trac.webkit.org/changeset/259871>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396042 [details].
Comment 6 Alexey Proskuryakov 2020-04-10 13:34:47 PDT 
Comment on attachment 396042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396042&action=review

> Source/WebCore/platform/graphics/ca/cocoa/WebTiledBackingLayer.mm:-58
> -    ASSERT_NOT_REACHED();

FWIW, the assertion was added with this comment: "Implement this and assert that it's never reached. We should never create presentation layers since we don't animate this layer."
Comment 7 Simon Fraser (smfr) 2020-04-10 20:01:09 PDT 
We plainly do animate this layer.