Bug 210295

Summary: Fix for crash in test accessibility/Mac/aria-grid-with-strange-hierarchy.html in isolated tree mode.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2020-04-09 12:07:57 PDT
Fix for crash in test accessibility/Mac/aria-grid-with-strange-hierarchy.html in isolated tree mode.
Comment 1 Andres Gonzalez 2020-04-09 12:28:23 PDT
Created attachment 395989 [details]
Patch
Comment 2 chris fleizach 2020-04-09 12:35:53 PDT
Comment on attachment 395989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395989&action=review

> Source/WebCore/ChangeLog:20
> +        - Added strcter assert checks to catch problems with the management of

stricter

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:217
>      auto object = nodeForID(axObjectID);

should we assert that the lock is hold in nodeForID() ?
Comment 3 Andres Gonzalez 2020-04-09 13:18:51 PDT
Created attachment 395995 [details]
Patch
Comment 4 EWS 2020-04-09 14:55:57 PDT
Committed r259832: <https://trac.webkit.org/changeset/259832>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395995 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-09 14:56:14 PDT
<rdar://problem/61541961>