Bug 210292

Summary:

[Flatpak SDK] Flatpak build broken when using 'git config core.webkitbranchbuild=true'

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

Tools / Tests

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

ews-watchlist, jbedard, pnormand, webkit-bug-importer, zan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	zan: review+

Description Nikolas Zimmermann 2020-04-09 11:06:13 PDT

The baseProductDir() contains the git branch name WebKitBuild/my_branch if that option is activated.
The flatpak detection assumes that $baseProductDir/UserFlatpak holds the Flatpak data, that is no longer true within this setup.

Let's think about how to fix this :-)

Comment 1 Philippe Normand 2020-04-10 03:29:14 PDT

Created attachment 396072 [details]
Patch

Comment 2 Philippe Normand 2020-04-10 04:07:00 PDT

Committed r259864: <https://trac.webkit.org/changeset/259864>

Comment 3 Radar WebKit Bug Importer 2020-04-10 04:07:11 PDT

<rdar://problem/61577164>