Bug 210276

Created attachment 401632 [details]
Patch

Comment on attachment 401632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401632&action=review

> Tools/MiniBrowser/gtk/BrowserSearchBox.c:74
> +    action = g_action_map_lookup_action(G_ACTION_MAP(searchBox->actionGroup), "beginnig-word");

Typo: beginnig → beginning.

I saw this in one of the dependant patches, so if you fix it on the other
patch first I suppose when you rebase this one you'll get it fixed, too :)

> Tools/MiniBrowser/gtk/BrowserSearchBox.c:131
> +    gtk_editable_set_text(GTK_EDITABLE(searchBox->entry), "");

I was about to mention this could be in “GtkVersioning.h”, but of
course we only want to use public headers in the MiniBrowser 😅️

Maybe it would be neat to have such a header for the MiniBrowser?
My feeling is that it would simplify quite a lot the #if-#endif
churn in many places along this patch.

(In reply to Adrian Perez from comment #2)
> Comment on attachment 401632 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401632&action=review
> 
> > Tools/MiniBrowser/gtk/BrowserSearchBox.c:74
> > +    action = g_action_map_lookup_action(G_ACTION_MAP(searchBox->actionGroup), "beginnig-word");
> 
> Typo: beginnig → beginning.
> 
> I saw this in one of the dependant patches, so if you fix it on the other
> patch first I suppose when you rebase this one you'll get it fixed, too :)
> 
> > Tools/MiniBrowser/gtk/BrowserSearchBox.c:131
> > +    gtk_editable_set_text(GTK_EDITABLE(searchBox->entry), "");
> 
> I was about to mention this could be in “GtkVersioning.h”, but of
> course we only want to use public headers in the MiniBrowser 😅️
> 
> Maybe it would be neat to have such a header for the MiniBrowser?
> My feeling is that it would simplify quite a lot the #if-#endif
> churn in many places along this patch.

I thought about this, but MiniBrowser code doesn't change that much and I think it will be easier to remove the code when we stop supporting gtk3.

Committed r262939: <https://trac.webkit.org/changeset/262939>