Bug 210254

Summary: Implement a more efficient tagCFunction() tool.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210252    
Attachments:
Description Flags
proposed patch.
none
proposed patch. keith_miller: review+

Description Mark Lam 2020-04-09 01:00:39 PDT 
The current tagCFunctionPtr() tool does a lot of extra work that is not needed if we are tagging a function and not a potentially arbitrary pointer.  For example,
1. it doesn't need to do a null check.
2. it doesn't need to authenticate the function address.  The RELEASE_ASSERT used to enforce that authentication can also go away.
Comment 1 Mark Lam 2020-04-09 01:31:57 PDT 
Created attachment 395921 [details]
proposed patch.
Comment 2 Mark Lam 2020-04-09 01:38:04 PDT 
Created attachment 395922 [details]
proposed patch.
Comment 3 Keith Miller 2020-04-09 02:18:41 PDT 
Comment on attachment 395922 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2020-04-09 02:28:16 PDT 
Thanks for the review.  Landed in r259786: <http://trac.webkit.org/r259786>.
Comment 5 Radar WebKit Bug Importer 2020-04-09 02:29:17 PDT 
<rdar://problem/61506122>