| Summary: | Web Inspector: Debugger: debug hooks should also be emitted for the first sub-expression in a comma expression | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | 209998 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Devin Rousso
2020-04-09 00:51:30 PDT
Created attachment 395920 [details]
Patch
Comment on attachment 395920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395920&action=review r=me > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3539 > if (!shouldEmitDebugHooks()) > return; Maybe we could use LIKELY macros here. Created attachment 395963 [details]
Patch
Comment on attachment 395963 [details]
Patch
Oops, that should be a `LIKELY` 😅
Created attachment 395967 [details]
Patch
Committed r259810: <https://trac.webkit.org/changeset/259810> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395967 [details]. |