Bug 210252

Summary: Use more PAC diversity for JIT probe code.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210254, 210314    
Bug Blocks:    
Attachments:
Description Flags
work in progress.
none
proposed patch. keith_miller: review+

Description Mark Lam 2020-04-09 00:50:15 PDT 
<rdar://problem/54490367>
Comment 1 Mark Lam 2020-04-09 02:34:53 PDT 
Created attachment 395927 [details]
work in progress.
Comment 2 Mark Lam 2020-04-10 11:25:47 PDT 
Created attachment 396107 [details]
proposed patch.
Comment 3 Keith Miller 2020-04-10 13:12:55 PDT 
Comment on attachment 396107 [details]
proposed patch.

r=me. Can you confirm the failing JSC test isn't related to your patch though?
Comment 4 Mark Lam 2020-04-10 13:21:37 PDT 
Thanks for the review.

(In reply to Keith Miller from comment #3)
> Comment on attachment 396107 [details]
> proposed patch.
> 
> r=me. Can you confirm the failing JSC test isn't related to your patch
> though?

The failing test is stress/regress-189028.js.ftl-eager.  It does not reproduce for me locally.  Hence, it's not due to my patch.
Comment 5 Mark Lam 2020-04-10 13:28:09 PDT 
Landed in r259897: <http://trac.webkit.org/r259897>.
Comment 6 Mark Lam 2020-04-16 14:41:09 PDT 
Rolled out r259897 in r260222: <http://trac.webkit.org/r260222>.
Comment 7 Mark Lam 2020-04-16 15:37:02 PDT 
The issue was just a debug ASSERT that does not apply for non-ARM64E builds.

Re-landed in r260223: <http://trac.webkit.org/r260223>.