Bug 210250

Summary: Set ENTITLEMENTS_REQUIRED=NO for some Xcode build targets
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric.carlson, ews-watchlist, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Keith Rollin 2020-04-09 00:37:30 PDT 
When building with the public version of Xcode 11.4, with XCBuild enabled, and targeting the iOS device, some build targets issue an error like:

error: An empty identity is not valid when signing a binary for the product type 'Command-line Tool'. (in target 'yasm' from project 'libwebrtc')

A comment in <rdar://problem/47092353> suggests setting ENTITLEMENTS_REQUIRED=NO to relax the requirement. To that end, when building with the public Xcode, establish that setting for the affected targets.
Comment 1 Radar WebKit Bug Importer 2020-04-09 00:37:39 PDT 
<rdar://problem/61502270>
Comment 2 Keith Rollin 2020-04-09 00:40:49 PDT 
Created attachment 395918 [details]
Patch
Comment 3 Jonathan Bedard 2020-04-09 07:29:09 PDT 
Comment on attachment 395918 [details]
Patch

Can we try to remove IDEProvisioningProfileSupportRelaxed=YES from webkitdirs and see what EWS says?
Comment 4 Keith Rollin 2020-04-09 10:12:15 PDT 
(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 395918 [details]
> Patch
> 
> Can we try to remove IDEProvisioningProfileSupportRelaxed=YES from
> webkitdirs and see what EWS says?

I'm not sure what you're trying to determine. Do you want this change in addition to the one already in this patch? If so, are you trying to see if IDEProvisioningProfileSupportRelaxed=YES is no longer necessary?
Comment 5 Jonathan Bedard 2020-04-09 10:14:21 PDT 
(In reply to Keith Rollin from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > Comment on attachment 395918 [details]
> > Patch
> > 
> > Can we try to remove IDEProvisioningProfileSupportRelaxed=YES from
> > webkitdirs and see what EWS says?
> 
> I'm not sure what you're trying to determine. Do you want this change in
> addition to the one already in this patch? If so, are you trying to see if
> IDEProvisioningProfileSupportRelaxed=YES is no longer necessary?

Yes, I'm curious if this change makes IDEProvisioningProfileSupportRelaxed=YES no longer required. That might not be the case, but EWS will tell us quickly either way.
Comment 6 Keith Rollin 2020-04-09 10:29:26 PDT 
Created attachment 395974 [details]
Patch
Comment 7 Keith Rollin 2020-04-09 11:59:29 PDT 
The green bubbles seem to be saying it works.
Comment 8 Jonathan Bedard 2020-04-09 12:07:02 PDT 
(In reply to Keith Rollin from comment #7)
> The green bubbles seem to be saying it works.

A bit concerned because it didn't clean build. I have a local OpenSource machine that I'm testing on now.
Comment 9 Jonathan Bedard 2020-04-09 13:25:01 PDT 
Comment on attachment 395974 [details]
Patch

Just ran this patch with a clean build on a customer machine, seems to be good to go!
Comment 10 Keith Rollin 2020-04-09 13:41:34 PDT 
Thanks for double-checking.
Comment 11 EWS 2020-04-09 13:52:04 PDT 
Committed r259826: <https://trac.webkit.org/changeset/259826>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395974 [details].