Bug 210245

Summary:	REGRESSION (r259737-r259758): Catalina Release WK2 Perf tests failing
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	pvollan, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ryan Haddad 2020-04-08 20:56:16 PDT

All 203 Catalina Release WK2 Perf tests are failing as of r259758:

https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Perf/builds/637

The output isn't terribly helpful:

Running Animation/balls.html (1 of 203)
FAILED
Finished: 11.089873 s

Comment 1 Radar WebKit Bug Importer 2020-04-08 20:56:32 PDT

<rdar://problem/61494708>

Comment 2 Ryan Haddad 2020-04-08 20:57:06 PDT

Looks like the tests are crashing:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebKit                    0x00000001092fe203 WebKit::AuxiliaryProcess::initializeSandbox(WebKit::AuxiliaryProcessInitializationParameters const&, WebKit::SandboxInitializationParameters&) + 6485 (AuxiliaryProcessMac.mm:666)
1   com.apple.WebKit                    0x000000010957ccf7 WebKit::WebProcess::initializeSandbox(WebKit::AuxiliaryProcessInitializationParameters const&, WebKit::SandboxInitializationParameters&) + 171 (WebProcessCocoa.mm:605)
2   com.apple.WebKit                    0x000000010911f00d WebKit::AuxiliaryProcess::initialize(WebKit::AuxiliaryProcessInitializationParameters const&) + 101 (AuxiliaryProcess.cpp:79)
3   com.apple.WebKit                    0x00000001094ed6fb void WebKit::XPCServiceInitializer<WebKit::WebProcess, WebKit::XPCServiceInitializerDelegate>(WTF::OSObjectPtr<NSObject<OS_xpc_object>*>, NSObject<OS_xpc_object>*, NSObject<OS_xpc_object>*) + 645 (XPCServiceEntryPoint.h:138)
4   com.apple.WebKit                    0x00000001094ed440 WebContentServiceInitializer + 61 (WebContentServiceEntryPoint.mm:53)
5   com.apple.WebKit                    0x00000001092bfa47 invocation function for block in WebKit::XPCServiceEventHandler(NSObject<OS_xpc_object>*) + 418 (XPCServiceMain.mm:93)
6   libxpc.dylib                        0x00007fff6808ca54 _xpc_connection_call_event_handler + 56
7   libxpc.dylib                        0x00007fff6808b95c _xpc_connection_mach_event + 927
8   libdispatch.dylib                   0x00007fff67de95ae _dispatch_client_callout4 + 9
9   libdispatch.dylib                   0x00007fff67dfeaeb _dispatch_mach_msg_invoke + 435
10  libdispatch.dylib                   0x00007fff67dee980 _dispatch_lane_serial_drain + 263
11  libdispatch.dylib                   0x00007fff67dff63e _dispatch_mach_invoke + 481
12  libdispatch.dylib                   0x00007fff67df4a82 _dispatch_main_queue_callback_4CF + 783
13  com.apple.CoreFoundation            0x00007fff3072c9a5 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
14  com.apple.CoreFoundation            0x00007fff306ec6fd __CFRunLoopRun + 2384
15  com.apple.CoreFoundation            0x00007fff306eb738 CFRunLoopRunSpecific + 503
16  com.apple.Foundation                0x00007fff32db31a8 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 212
17  com.apple.Foundation                0x00007fff32e66d8b -[NSRunLoop(NSRunLoop) run] + 76
18  libxpc.dylib                        0x00007fff680960e1 _xpc_objc_main.cold.4 + 49
19  libxpc.dylib                        0x00007fff68096027 _xpc_objc_main + 559
20  libxpc.dylib                        0x00007fff68095b5a xpc_main + 377
21  com.apple.WebKit                    0x00000001092bbc1f WebKit::XPCServiceMain(int, char const**) + 554
22  libdyld.dylib                       0x00007fff67e427fd start + 1

Comment 3 Ryan Haddad 2020-04-08 20:58:06 PDT

There are a few sandbox changes in the range:
https://trac.webkit.org/log/webkit/?action=stop_on_copy&mode=stop_on_copy&rev=259758&stop_rev=259737&limit=100&verbose=on

Comment 4 Ryan Haddad 2020-04-08 20:59:17 PDT

Allow use of syscall from the WebContent sandbox
https://trac.webkit.org/changeset/259758/webkit

[macOS] Crash under WebKit::SandboxExtension::consume
https://trac.webkit.org/changeset/259753/webkit

Comment 5 Ryan Haddad 2020-04-08 21:18:54 PDT

Probably fixed by https://trac.webkit.org/changeset/259779/webkit