Bug 210217

Summary: [LLInt] Add fast path for TypedArray access on LLInt 32-bits
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Caio Lima
Reported 2020-04-08 15:20:39 PDT
...
Attachments
Patch (11.51 KB, patch)
2020-04-08 16:41 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (11.50 KB, patch)
2020-04-08 17:50 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.65 KB, patch)
2020-04-10 03:25 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2020-04-08 16:41:29 PDT
Created attachment 395886 [details] Patch
Caio Lima
Comment 2 2020-04-08 17:50:19 PDT
Created attachment 395892 [details] Patch
Yusuke Suzuki
Comment 3 2020-04-09 17:18:16 PDT
Comment on attachment 395892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395892&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1565 > + getByValTypedArray(t0, t1, finishIntGetByVal, finishDoubleGetByVal, .opGetByValSlow, cagedPrimitive) You should define `cagedPrimitive` in 32bit LowLevelInterpreter as empty macro instead of passing it to getByValTypedArray
Caio Lima
Comment 4 2020-04-10 03:25:48 PDT
Created attachment 396071 [details] Patch for landing Thank you very much for the review
EWS
Comment 5 2020-04-10 05:19:46 PDT
Committed r259866: <https://trac.webkit.org/changeset/259866> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396071 [details].
Radar WebKit Bug Importer
Comment 6 2020-04-10 05:20:14 PDT
<rdar://problem/61579403>
Note You need to log in before you can comment on or make changes to this bug.