| Summary: | [LLInt] Add fast path for TypedArray access on LLInt 32-bits | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caio Lima <ticaiolima> | ||||||||
| Component: | JavaScriptCore | Assignee: | Caio Lima <ticaiolima> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Caio Lima
2020-04-08 15:20:39 PDT
Created attachment 395886 [details]
Patch
Created attachment 395892 [details]
Patch
Comment on attachment 395892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395892&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1565 > + getByValTypedArray(t0, t1, finishIntGetByVal, finishDoubleGetByVal, .opGetByValSlow, cagedPrimitive) You should define `cagedPrimitive` in 32bit LowLevelInterpreter as empty macro instead of passing it to getByValTypedArray Created attachment 396071 [details]
Patch for landing
Thank you very much for the review
Committed r259866: <https://trac.webkit.org/changeset/259866> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396071 [details]. |