Bug 210213

Summary: Release WebGLLayer earlier in ~GraphicsContextGLOpenGL
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dino, ews-watchlist, graouts, justin_fan, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210151    
Bug Blocks: 210153, 210222    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2020-04-08 14:40:44 PDT
In GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL in Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm, the native context is deleted and [WebGLLayer setContext:] called immediately afterward to clear out its NakedPtr<GraphicsContextGLOpenGL>. In order to allow WebGLLayer's cleanup code to potentially do work with the native context, it seems appropriate to release the WebGLLayer earlier. May be related to other recently filed crashes.
Attachments
Patch (3.23 KB, patch)
2020-04-08 14:44 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-04-08 14:44:06 PDT
Created attachment 395871 [details] Patch
EWS
Comment 2 2020-04-08 15:57:56 PDT
Committed r259764: <https://trac.webkit.org/changeset/259764> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395871 [details].
Radar WebKit Bug Importer
Comment 3 2020-04-08 15:58:13 PDT
<rdar://problem/61482594>
Ryan Haddad
Comment 4 2020-04-10 17:41:42 PDT
Reverted r259764 for reason: Causes layout test crashes under GuardMalloc Committed r259915: <https://trac.webkit.org/changeset/259915>
Ryan Haddad
Comment 5 2020-04-10 17:44:23 PDT
(In reply to Ryan Haddad from comment #4) > Reverted r259764 for reason: > > Causes layout test crashes under GuardMalloc > > Committed r259915: <https://trac.webkit.org/changeset/259915> We were seeing crashes on iOS Simulator when running tests under GuardMalloc These are some of the tests that hit crashes: fast/canvas/webgl/no-info-log-for-simple-shaders.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html webgl/1.0.3/conformance/extensions/ext-blend-minmax.html fast/canvas/webgl/no-info-log-for-simple-shaders.html
Kenneth Russell
Comment 6 2020-04-10 18:16:26 PDT
Thanks Ryan and sorry about the crashes. Was worried about that. How can I run my local iOS Simulator build with GuardMalloc?
Kenneth Russell
Comment 7 2020-04-13 16:11:44 PDT
Note - per fix in Bug 210222, if that one lands and sticks, I'll likely close this as WontFix rather than trying to pursue it further.
Kenneth Russell
Comment 8 2020-04-20 11:21:38 PDT
The fix for Bug 210222 seems that it's stable and won't be reverted, so closing this out as WontFix.
Note You need to log in before you can comment on or make changes to this bug.