Bug 210207

Summary: Web Inspector: Search: populate the search field with the current selection when using the global search shortcut
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-04-08 11:46:50 PDT
This is one of the things I love most about Sublime Text, in that I can select something, press ⇧⌘F, and immediately search for the selected string throughout my project without having to copy/paste it.
Attachments
Patch (5.20 KB, patch)
2020-04-08 11:47 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-04-08 11:47:41 PDT
Created attachment 395848 [details] Patch
Timothy Hatcher
Comment 2 2020-04-08 11:53:45 PDT
Comment on attachment 395848 [details] Patch Should we just hook up Command-E? That is a system wide shortcut for this. No need for a preference in that case.
Devin Rousso
Comment 3 2020-04-08 12:00:47 PDT
(In reply to Timothy Hatcher from comment #2) > Should we just hook up Command-E? That is a system wide shortcut for this. No need for a preference in that case. This is for the global search (⇧⌘F), not searching within a given resource. I think it makes sense to have it as a setting instead of always on because some people may use ⇧⌘F as just a way of quickly going to the Search Tab, not necessarily wanting to alter the current search query. We already have support for ⌘E from within Web Inspector (it doesn't propagate from the rest of the system though <https://webkit.org/b/151310>).
EWS
Comment 4 2020-04-08 13:02:22 PDT
Committed r259748: <https://trac.webkit.org/changeset/259748> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395848 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-08 13:03:12 PDT
<rdar://problem/61471963>
Note You need to log in before you can comment on or make changes to this bug.