| Summary: | Web Inspector: Search: populate the search field with the current selection when using the global search shortcut | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | hi, inspector-bugzilla-changes, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Devin Rousso
2020-04-08 11:46:50 PDT
Created attachment 395848 [details]
Patch
Comment on attachment 395848 [details]
Patch
Should we just hook up Command-E? That is a system wide shortcut for this. No need for a preference in that case.
(In reply to Timothy Hatcher from comment #2) > Should we just hook up Command-E? That is a system wide shortcut for this. No need for a preference in that case. This is for the global search (⇧⌘F), not searching within a given resource. I think it makes sense to have it as a setting instead of always on because some people may use ⇧⌘F as just a way of quickly going to the Search Tab, not necessarily wanting to alter the current search query. We already have support for ⌘E from within Web Inspector (it doesn't propagate from the rest of the system though <https://webkit.org/b/151310>). Committed r259748: <https://trac.webkit.org/changeset/259748> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395848 [details]. |