| Summary: | Make more use of FrameLoader pageID/frameID getters | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||
| Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, kangil.han, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Rob Buis
2020-04-08 04:35:56 PDT
Created attachment 395791 [details]
Patch
Comment on attachment 395791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395791&action=review > Source/WebCore/loader/FrameLoader.cpp:154 > +#define PAGE_ID ((client().pageID().valueOr(PageIdentifier())).toUInt64()) Well it was used here and the getter did not do any harm. I don't understand why we want to drop these getters. FrameLoader is quite big and complicated, I am trying to slim it down (will take a long time obviously). If you do not like this particular patch too much, how about at least making it private and not exported? I'll rename the bug of course. (In reply to Rob Buis from comment #3) > FrameLoader is quite big and complicated, I am trying to slim it down (will > take a long time obviously). If you do not like this particular patch too > much, how about at least making it private and not exported? I'll rename the > bug of course. If anything, I think that if anything that is using FrameLoader::client().frameID() should be fixed to use FrameLoader::frameID() instead. Created attachment 395824 [details]
Patch
(In reply to Chris Dumez from comment #4) > (In reply to Rob Buis from comment #3) > > FrameLoader is quite big and complicated, I am trying to slim it down (will > > take a long time obviously). If you do not like this particular patch too > > much, how about at least making it private and not exported? I'll rename the > > bug of course. > > If anything, I think that if anything that is using > FrameLoader::client().frameID() should be fixed to use > FrameLoader::frameID() instead. Ah, I had not considered that. Done! Committed r259752: <https://trac.webkit.org/changeset/259752> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395824 [details]. |