| Summary: | Remove ENABLE_INTL define | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, benjamin, bfulgham, cdumez, cmarcelo, darin, don.olmstead, ews-watchlist, gyuyoung.kim, Hironori.Fujii, jbedard, joepeck, keith_miller, mark.lam, msaboff, olivier.blin, pvollan, ryuan.choi, saam, sergio, stephan.szabo, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ross Kirsling
2020-04-07 15:33:49 PDT
Created attachment 395754 [details]
Patch
Why? This is important feature for developers of embedded systems, allowing to cut of some stuff from ICU (In reply to Konstantin Tokarev from comment #2) > Why? This is important feature for developers of embedded systems, allowing > to cut of some stuff from ICU As I wrote in WTF/ChangeLog, AppleWin was the only upstream platform turning it off. We could certainly leave this as an optional feature indefinitely, but it seems a bit problematic if there won't be any bots left to ensure that the build works without it. Note: AppleWin EWS doesn't run JSC tests but I've confirmed that they pass locally. As for downstream platforms -- I believe it's possible to stub out the data portion of ICU such that you can build and link, even if the output wouldn't pass our tests. Committed r259767: <https://trac.webkit.org/changeset/259767> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395754 [details]. *** Bug 186020 has been marked as a duplicate of this bug. *** |