Bug 210148

Summary: We can still cache delete in strict mode as long as the property is not "non-configurable"
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Description Saam Barati 2020-04-07 13:32:20 PDT 
Only deletes on non-configurable in strict mode throw
Comment 1 Saam Barati 2020-04-08 10:54:37 PDT 
Created attachment 395836 [details]
patch
Comment 2 Saam Barati 2020-04-08 10:55:34 PDT 
Comment on attachment 395836 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395836&action=review

> JSTests/microbenchmarks/delete-cache-strict-mode.js:27
> +noInline(doDel);

oops: this should be doDelByVal, will fix
Comment 3 Saam Barati 2020-04-08 10:56:28 PDT 
Created attachment 395837 [details]
patch
Comment 4 Tadeu Zagallo 2020-04-08 11:16:36 PDT 
Comment on attachment 395837 [details]
patch

r=me
Comment 5 EWS 2020-04-09 10:59:12 PDT 
Committed r259807: <https://trac.webkit.org/changeset/259807>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395837 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-09 11:00:16 PDT 
<rdar://problem/61527037>