Bug 210146

Summary: [ews] Improve summary for CheckPatchRelevance build step
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Aakash Jain 2020-04-07 13:16:24 PDT 
[ews] Improve summary for CheckPatchRelevance build step. 
Currently, if the patch doesn't have any relevant changes, the message is: 'Checked patch relevance (failure)', which is incorrect since there was no failure. It should be "Patch doesn't contain relevant changes".
Comment 1 Aakash Jain 2020-04-07 13:19:22 PDT 
Created attachment 395729 [details]
Patch
Comment 2 EWS 2020-04-07 17:38:39 PDT 
Committed r259694: <https://trac.webkit.org/changeset/259694>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395729 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-07 17:39:16 PDT 
<rdar://problem/61420422>
Comment 4 Aakash Jain 2020-04-08 09:19:55 PDT 
Landed follow-up fix in r259719 since the failure message for CheckPatchRelevance needs to match with status-bubble code https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py#L277