Bug 210137

Summary: Web Automation: Automation.inspectBrowsingContext should bring Web Inspector to front automatically
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebDriverAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, hi, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Blaze Burg
Reported 2020-04-07 11:50:29 PDT
.
Attachments
Patch (1.90 KB, patch)
2020-04-07 11:56 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2020-04-07 11:56:45 PDT
Created attachment 395719 [details] Patch
Joseph Pecoraro
Comment 2 2020-04-07 12:46:20 PDT
Comment on attachment 395719 [details] Patch rs=me
Devin Rousso
Comment 3 2020-04-07 12:48:28 PDT
Comment on attachment 395719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395719&action=review r=me > Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:59 > if (page->inspector()) { NIT: why not save this result so you don't have to call it again? ``` if (auto* inspector = page->inspector()) inspector->show(); ```
EWS
Comment 4 2020-04-07 13:07:52 PDT
Committed r259665: <https://trac.webkit.org/changeset/259665> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395719 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-07 13:08:13 PDT
<rdar://problem/61406816>
Note You need to log in before you can comment on or make changes to this bug.