Bug 210110

Summary: [GTK] CMake find module for GTK4
Product: WebKit Reporter: Adrian Perez <aperez>
Component: CMakeAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, cgarcia, clopez, darin, don.olmstead, ews-watchlist, fujii.hironori, gyuyoung.kim, ross.kirsling, ryuan.choi, sergio
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100, 210154    
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2020-04-07 07:24:18 PDT
We will need to be able to make CMake aware of GTK4, while still keeping the possibility to use GTK3. We can go about this in two possible ways: - Add a new FindGTK4.cmake file - Modify FindGTK3.cmake to support both versions and rename it to FindGTK.cmake. While at it, we could make the find module provide an imported target to simplify the build definitions and make the build more robust.
Attachments
Patch (22.39 KB, patch)
2020-04-07 07:40 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-04-07 07:40:37 PDT
Created attachment 395678 [details] Patch
EWS
Comment 2 2020-04-07 09:25:21 PDT
Committed r259641: <https://trac.webkit.org/changeset/259641> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395678 [details].
Note You need to log in before you can comment on or make changes to this bug.