Bug 210110

Summary: [GTK] CMake find module for GTK4
Product: WebKit Reporter: Adrian Perez <aperez>
Component: CMakeAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, cgarcia, clopez, darin, don.olmstead, ews-watchlist, gyuyoung.kim, Hironori.Fujii, ross.kirsling, ryuan.choi, sergio
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100, 210154    
Attachments:
Description Flags
Patch none

Description Adrian Perez 2020-04-07 07:24:18 PDT 
We will need to be able to make CMake aware of GTK4, while still
keeping the possibility to use GTK3. We can go about this in two
possible ways:

 - Add a new FindGTK4.cmake file
 - Modify FindGTK3.cmake to support both versions and rename it
   to FindGTK.cmake.

While at it, we could make the find module provide an imported
target to simplify the build definitions and make the build more
robust.
Comment 1 Adrian Perez 2020-04-07 07:40:37 PDT 
Created attachment 395678 [details]
Patch
Comment 2 EWS 2020-04-07 09:25:21 PDT 
Committed r259641: <https://trac.webkit.org/changeset/259641>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395678 [details].