Bug 210109

Summary: [Tools] Fix gdb WebCoreQualifiedNamePrinter
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: Tools / TestsAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2020-04-07 06:57:18 PDT
My gdb was throwing exceptions like this when printing QualifiedName's: File "/webkit/Tools/gdb/webkit.py", line 205, in __init__ self.val['m_impl']['m_prefix']['m_string']) gdb.error: There is no member or method named m_prefix. This patch adds a missing m_ptr indirection to traverse RefPtr<QualifiedNameImpl>, fixing the issue.
Attachments
Patch (1.98 KB, patch)
2020-04-07 06:58 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2020-04-07 06:58:22 PDT
Created attachment 395675 [details] Patch
Daniel Bates
Comment 2 2020-04-10 08:13:49 PDT
Comment on attachment 395675 [details] Patch Patch looks good. A better patch would add test infra and a test for this change though this can be done in a separate patch. Inspiration can be taken from test-lldbWebKit.
EWS
Comment 3 2020-04-10 08:19:03 PDT
Committed r259870: <https://trac.webkit.org/changeset/259870> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395675 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-10 08:20:17 PDT
<rdar://problem/61584950>
Alicia Boya García
Comment 5 2020-04-10 08:23:55 PDT
(In reply to Daniel Bates from comment #2) > A better patch would add test infra and a test for this > change though this can be done in a separate patch. Inspiration can be taken > from test-lldbWebKit. That would be a considerable effort since there is no test coverage for the whole gdb helper at the moment.
Note You need to log in before you can comment on or make changes to this bug.