| Summary: | Bump priority of LibWebRTCAudioModule thread | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
youenn fablet
2020-04-07 06:22:00 PDT
Created attachment 395676 [details]
Patch
Created attachment 395677 [details]
Patch
Created attachment 395951 [details]
Patch
Comment on attachment 395951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395951&action=review > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:73 > void LibWebRTCAudioModule::StartPlayoutOnAudioThread() This name seems wrong now that it is essentially a one-shot. Maybe something like `PullDataOnAudioThread`, or fold maybe the logic into PollFromSource instead? > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:102 > + char data[(LibWebRTCAudioFormat::sampleByteSize * channels * LibWebRTCAudioFormat::chunkSampleCount)]; Now that the chunk size is constant (for a given channel count), maybe we should use a member variable that is (re)allocated when the number of channels changes? Created attachment 395960 [details]
Patch for landing
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Created attachment 396053 [details]
Patch for landing
Committed r259853: <https://trac.webkit.org/changeset/259853> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396053 [details]. |